Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/services: convert HeartbeatMonitorCreateDialog to ts and use urql #2480

Merged
merged 7 commits into from
Jul 21, 2022
Merged

ui/services: convert HeartbeatMonitorCreateDialog to ts and use urql #2480

merged 7 commits into from
Jul 21, 2022

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Jun 29, 2022 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

Out of Scope:

  • switch to urql

@tony-tvu tony-tvu mentioned this pull request Jun 29, 2022
Open
@tony-tvu tony-tvu changed the title ui/services: convert HeartbeatMonitorCreateDialog to ts ui/services: convert HeartbeatMonitorCreateDialog to ts and use urql Jun 29, 2022
@tony-tvu tony-tvu marked this pull request as draft July 5, 2022 19:22
@tony-tvu tony-tvu marked this pull request as ready for review July 6, 2022 18:44
@KatieMSB KatieMSB requested a review from Forfold July 19, 2022 19:12
Forfold
Forfold previously approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Forfold Forfold mentioned this pull request Jul 19, 2022
Merged
7 tasks
@mastercactapus mastercactapus merged commit 6559f89 into master Jul 21, 2022
@mastercactapus mastercactapus deleted the ts-HeartbeatMonitorCreateDialog branch July 21, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@mastercactapus mastercactapus mastercactapus approved these changes

Assignees
No one assigned
Labels
ts-conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tony-tvu @mastercactapus @Forfold