Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/services: convert HeartbeatMonitorDeleteDialog to ts and use urql #2484

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

Out of Scope:

  • switch out Apollo client with urql

@KatieMSB KatieMSB requested a review from Forfold July 19, 2022 19:12
@mastercactapus mastercactapus merged commit 12e4721 into master Jul 19, 2022
@mastercactapus mastercactapus deleted the ts-HeartbeatMonitorDeleteDialog branch July 19, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants