Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/services: convert ServiceEditDialog to ts #2571

Closed
wants to merge 1 commit into from
Closed

ui/services: convert ServiceEditDialog to ts #2571

wants to merge 1 commit into from

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

Out of Scope:

  • switch out Apollo client with urql

@tony-tvu tony-tvu mentioned this pull request Aug 18, 2022
Open
@tony-tvu tony-tvu changed the title ui/services: convert ServiceLabelEditDialog to ts ui/services: convert ServiceEditDialog to ts Sep 23, 2022
@tony-tvu
Copy link
Collaborator Author

This was a duplicate TS conversion pr - ServiceEditDialog has already been converted.

@tony-tvu tony-tvu closed this Sep 23, 2022
@tony-tvu tony-tvu deleted the typescript-ServiceLabelEditDialog branch April 18, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
ts-conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tony-tvu @KatieMSB