-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: breaking out voice calls into a testable function #2768
feat: breaking out voice calls into a testable function #2768
Conversation
…-a-testable-function
…-a-testable-function
A table test isn't a good fit for testing Better would be to either break each message type into its unit test (e.g., Table testing is helpful for simple cases, like strings, or lots of variation when all inputs are very similar. Each message type is different in this case, and it doesn't help to bundle them together because, for each set, the input and output for each message type are drastically different. |
took care of it by taking it it out of the table. dismissing since the item has now been addressed so we can move forward
make check
to catch common errors. Fixed any that came up.Description:
Broke out the building of a phone call from a large monolithic function into its own, smaller, and testable function.
Which issue(s) this PR fixes:
Part of addressing #2576
Out of Scope:
changes to the voice xml building functionality.
Screenshots:
NA
Describe any introduced user-facing changes:
NA
Describe any introduced API changes:
NA
Additional Info:
NA