-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding webhooks as a notification channel type #2809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I'm going through this, I wonder if we should qualify Webhook
everywhere to reduce ambiguity; nc-webhook
and user-webhook
vs. webhook
on its own for either one.
Thoughts?
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Since there will be more than one type of Webhook, we should ensure that there's a prefix to help everyone know what kind of webhook it is. |
Just added the new |
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
If I add the new |
I see; having it here would certainly help validate the API and DB changes -- is it possible to include just the minimal API <-> DB bits? If not, we can leave it out of scope. |
Sure, just added it. |
make check
to catch common errors. Fixed any that came up.Description:
Adds support for webhooks as a notification channel.
Which issue(s) this PR fixes:
Part of #2691
Splitting up #2774