Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/UserLink: convert to typescript #2850

Merged
merged 1 commit into from
Mar 10, 2023
Merged

ui/UserLink: convert to typescript #2850

merged 1 commit into from
Mar 10, 2023

Conversation

NickHackman
Copy link
Contributor

@NickHackman NickHackman commented Mar 10, 2023 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

@NickHackman NickHackman marked this pull request as ready for review March 10, 2023 16:09
@KatieMSB KatieMSB merged commit fc34fcd into target:master Mar 10, 2023
@NickHackman NickHackman deleted the ui-UserLink-to-tsx branch March 10, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

@mastercactapus mastercactapus mastercactapus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickHackman @mastercactapus @KatieMSB