Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/alerts: Convert CreateAlertConfirm to typescript #2938

Closed
wants to merge 1 commit into from
Closed

ui/alerts: Convert CreateAlertConfirm to typescript #2938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ...tDialog/StepContent/CreateAlertConfirm.js → ...Dialog/StepContent/CreateAlertConfirm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,20 @@ const useStyles = makeStyles({
},
})

export function CreateAlertConfirm() {
export function CreateAlertConfirm(): JSX.Element {
const classes = useStyles()

const renderItem = ({ name, label, value, children }) => (
const renderItem = ({
name,
label,
value,
children,
}: {
name: string
label: string
value: string
children: JSX.Element
}): JSX.Element => (
<Grid item xs={12}>
<Typography
variant='subtitle1'
Expand Down Expand Up @@ -56,7 +66,7 @@ export function CreateAlertConfirm() {
renderItem({
...otherProps,
label: `Selected Services (${value.length})`,
children: value.map((id) => (
children: value.map((id: string) => (
<ServiceChip
key={id}
clickable={false}
Expand Down