Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webhook check on edit escalation policy step #3040

Merged
merged 3 commits into from
May 30, 2023
Merged

fix: webhook check on edit escalation policy step #3040

merged 3 commits into from
May 30, 2023

Conversation

andrewbenington
Copy link
Contributor

@andrewbenington andrewbenington commented May 23, 2023 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Adding backend check for webhooks added to existing escalation steps.
Uses the same validation logic as creating a new step.

Which issue(s) this PR fixes:
Fixes #3039

Attachments
This error will appear when editing a step to include a forbidden webhook:
Screenshot 2023-05-30 at 3 00 52 PM

allending313
allending313 approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@allending313 allending313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrewbenington andrewbenington merged commit e9c65e0 into master May 30, 2023
@andrewbenington andrewbenington deleted the edit-esc-step-webhook-check branch May 30, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allending313 allending313 allending313 approved these changes

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Awaiting requested review from Forfold

@ethan-haynes ethan-haynes Awaiting requested review from ethan-haynes

@m17ch m17ch Awaiting requested review from m17ch

@KatieMSB KatieMSB Awaiting requested review from KatieMSB

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

escalation policies: restrict webhooks to admin allowed URLs
3 participants
@andrewbenington @mastercactapus @allending313