Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in SMTP ingress server #3184

Merged
merged 43 commits into from
Aug 9, 2023
Merged

Conversation

nimjor
Copy link
Contributor

@nimjor nimjor commented Jul 20, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This adds a feature to enable built-in SMTP email ingress for creating alerts without dependence on Mailgun. It is configured using command-line flags/env vars as specified in #3136.

Which issue(s) this PR fixes:
Fixes #3136

Out of Scope:
This built-in SMTP server is only used for email receipt, for generating alerts. It is not responsible for sending outgoing mail notifications.

Screenshots:
n/a

Describe any introduced user-facing changes:
n/a

Describe any introduced API changes:
n/a

Additional Info:
n/a

@mastercactapus mastercactapus self-assigned this Jul 24, 2023
@mastercactapus mastercactapus self-requested a review July 24, 2023 15:48
@mastercactapus mastercactapus merged commit 1e97e44 into target:master Aug 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Direct SMTP Server Option for Alert Creation
3 participants