Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add user shifts calendar to profile #3229

Merged
merged 40 commits into from
Nov 28, 2023
Merged

ui: add user shifts calendar to profile #3229

merged 40 commits into from
Nov 28, 2023

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Aug 15, 2023 •
edited
Loading

Description:

  • This PR introduces a calendar (found within the Profile Quick Links) that will by default display an aggregate of all schedule shifts the user currently

Which issue(s) this PR fixes:

Describe any introduced user-facing changes:

  • Shows personalized calendar under contact methods and notifications rules on the profile (when not mobile)
  • Schedule Calendar Subscriptionsquick link renamed toExternal Calendar Subscriptions`
  • Updates quick link URL /profile/sessions to /profile/active-sessions to match quick link text

Screenshots:

Screenshot 2023-10-27 at 2 44 47 PM Screenshot 2023-10-27 at 2 46 08 PM

@Forfold Forfold mentioned this pull request Aug 16, 2023
Merged
@Forfold
Copy link
Contributor Author

Forfold commented Oct 2, 2023

Blocked by #3286

@Forfold Forfold marked this pull request as ready for review October 27, 2023 18:46
@Forfold Forfold changed the title api/ui: add user shifts calendar to profile ui: add user shifts calendar to profile Oct 27, 2023
KatieMSB
KatieMSB previously approved these changes Nov 22, 2023
View reviewed changes
mastercactapus
mastercactapus previously requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the walkthrough; In the future, let's try to do renames/cleanup/refactors/prereq-changes in separate PRs so they aren't tied to the new code. Great work!

web/src/app/users/UserContactMethodList.tsx Outdated Show resolved Hide resolved
web/src/app/users/UserNotificationRuleList.tsx Outdated Show resolved Hide resolved
web/src/app/users/UserShiftsCalendar.tsx Outdated Show resolved Hide resolved
web/src/app/util/calendar/CalendarEventWrapper.tsx Outdated Show resolved Hide resolved
ethan-haynes
ethan-haynes previously approved these changes Nov 22, 2023
View reviewed changes
KatieMSB
KatieMSB previously approved these changes Nov 22, 2023
View reviewed changes
@Forfold Forfold dismissed stale reviews from KatieMSB and ethan-haynes via 3e808e6 November 22, 2023 22:04
ethan-haynes
ethan-haynes previously approved these changes Nov 22, 2023
View reviewed changes
KatieMSB
KatieMSB previously approved these changes Nov 28, 2023
View reviewed changes
tony-tvu
tony-tvu previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally working as expected 👍

@Forfold Forfold dismissed stale reviews from tony-tvu and KatieMSB via 83eb81f November 28, 2023 20:26
@tony-tvu tony-tvu merged commit 81675bc into master Nov 28, 2023
7 checks passed
@tony-tvu tony-tvu deleted the user-shifts branch November 28, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus left review comments

@tony-tvu tony-tvu tony-tvu approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

@ethan-haynes ethan-haynes Awaiting requested review from ethan-haynes

Assignees
No one assigned
Labels
size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single user calendar view across schedules
5 participants
@Forfold @mastercactapus @ethan-haynes @KatieMSB @tony-tvu