feat: add monthly rotation option #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
requested changes
Aug 22, 2023
Forfold
previously approved these changes
Aug 31, 2023
Forfold
previously approved these changes
Sep 5, 2023
mastercactapus
requested changes
Sep 5, 2023
mastercactapus
requested changes
Sep 11, 2023
mastercactapus
previously approved these changes
Sep 12, 2023
Forfold
reviewed
Sep 12, 2023
Forfold
reviewed
Sep 12, 2023
Forfold
previously approved these changes
Sep 12, 2023
Forfold
previously approved these changes
Sep 13, 2023
mastercactapus
approved these changes
Sep 13, 2023
Forfold
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Currently, we have daily, weekly, and hourly rotations. It would be nice if we can have a monthly on-call rotation. For Ex: 1st of every month.
Added support for monthly rotations where rotations start at the beginning of every month and end at the end of the month.
This PR is for the backend component of this feature.
Which issue(s) this PR fixes:
#3196
Describe any introduced API changes:
Introduce new monthly rotation type
Other changes:
The smoketest for a monthly rotation has to fast-forward time more than the 30-day session expiration; The harness has been updated to handle refreshing its session.