Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark many alerts as noise from alerts list #3265

Merged
merged 17 commits into from
Sep 28, 2023
Merged

mark many alerts as noise from alerts list #3265

merged 17 commits into from
Sep 28, 2023

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Sep 6, 2023 •
edited
Loading

Description:

  • Adds the option to mark alerts from within the alerts list as noise. This allows users to select many alerts at once, rather than needing to open each alert in a new tab to set the alert's noise reason.

Which issue(s) this PR fixes:

Screenshots:

Screenshot 2023-09-12 at 9 47 45 AM

Screenshot 2023-09-06 at 11 00 39 AM

Screenshot 2023-09-06 at 11 00 45 AM

Screenshot 2023-09-06 at 11 01 00 AM

Describe any introduced user-facing changes:

  • New icon for marking alerts as noise to click on when checking alerts from alert list

Describe any introduced API changes:

  • Adds the noiseReason field to the updateAlerts mutation

@Forfold Forfold marked this pull request as draft September 6, 2023 18:07
@github-actions github-actions bot added the size/l label Sep 6, 2023
@Forfold Forfold marked this pull request as ready for review September 6, 2023 19:49
@mastercactapus
Copy link
Member

mastercactapus commented Sep 12, 2023 •
edited
Loading

I like how on the details page we ask Is this alert noise? with a list of reasons -- can we do something similar with phrasing here?

Maybe:

  • Instead of the hover text "Set Noise Reason" maybe "Mark as Noise"
  • Instead of the title 'Set Selected Alerts Noise Reason' maybe "Mark Alerts as Noise" or "Why are these noise?" since the next line is Alerts: with a list.

@Forfold
Copy link
Contributor Author

Forfold commented Sep 13, 2023

I originally had "Mark as Noise" but wasn't sure if it was fitting. I'll play around with it!

mastercactapus
mastercactapus previously approved these changes Sep 26, 2023
View reviewed changes
@Forfold Forfold merged commit dda167f into master Sep 28, 2023
6 checks passed
@Forfold Forfold deleted the alerts-mark-many-noise branch September 28, 2023 20:40
andrewbenington added a commit that referenced this pull request Oct 6, 2023
@andrewbenington
Squashed commit of the following:
79c160a 
commit dda167f
Author: Nathaniel Cook <NathanielJCook@outlook.com>
Date:   Thu Sep 28 13:40:51 2023 -0700

    mark many alerts as noise from alerts list (#3265)

    * add noiseReason to updateAlerts

    * fix type mismatch when setting alert IDs

    * move slice type cast

    * add feedback dialog

    * fix status not being update in list

    * return alert ids from updating feedback

    * add submit with snackbar notification

    * add cypress e2e test for many alerts noise reason

    * update icon

    * formatting and column name fix

    * deprecate setAlertNoiseReason

    * validate number of alerts

    * don't allow newStatus with noiseReason

    * move var decl

    * update titles for alert list noise feedback

    * add title test tag

    ---------

    Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbenington andrewbenington andrewbenington approved these changes

@mastercactapus mastercactapus mastercactapus approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulk Application of Feedback to Alerts
3 participants
@Forfold @mastercactapus @andrewbenington