user/favorite: use sqlc for user favorites

app/initstores.go

@@ -235,7 +235,7 @@ func (app *App) initStores(ctx context.Context) error {
 	}
 
 	if app.FavoriteStore == nil {
-		app.FavoriteStore, err = favorite.NewStore(ctx, app.db)
+		app.FavoriteStore, err = favorite.NewStore(ctx)
 	}
 	if err != nil {
 		return errors.Wrap(err, "init favorite store")

graphql2/graphqlapp/alert.go

@@ -188,7 +188,7 @@ func (q *Query) Alert(ctx context.Context, alertID int) (*alert.Alert, error) {
  * Merges favorites and user-specified serviceIDs in opts.FilterByServiceID
  */
 func (q *Query) mergeFavorites(ctx context.Context, svcs []string) ([]string, error) {
-	targets, err := q.FavoriteStore.FindAll(ctx, permission.UserID(ctx), []assignment.TargetType{assignment.TargetTypeService})
+	targets, err := q.FavoriteStore.FindAll(ctx, q.DB, permission.UserID(ctx), []assignment.TargetType{assignment.TargetTypeService})
 	if err != nil {
 		return nil, err
 	}

graphql2/graphqlapp/escalationpolicy.go

@@ -141,7 +141,7 @@ func (m *Mutation) CreateEscalationPolicy(ctx context.Context, input graphql2.Cr
 			return err
 		}
 		if input.Favorite != nil && *input.Favorite {
-			err = m.FavoriteStore.SetTx(ctx, tx, permission.UserID(ctx), assignment.EscalationPolicyTarget(pol.ID))
+			err = m.FavoriteStore.Set(ctx, tx, permission.UserID(ctx), assignment.EscalationPolicyTarget(pol.ID))
 			if err != nil {
 				return err
 			}

graphql2/graphqlapp/mutation.go

@@ -31,9 +31,9 @@ func (a *App) Mutation() graphql2.MutationResolver { return (*Mutation)(a) }
 func (a *Mutation) SetFavorite(ctx context.Context, input graphql2.SetFavoriteInput) (bool, error) {
 	var err error
 	if input.Favorite {
-		err = a.FavoriteStore.Set(ctx, permission.UserID(ctx), input.Target)
+		err = a.FavoriteStore.Set(ctx, a.DB, permission.UserID(ctx), input.Target)
 	} else {
-		err = a.FavoriteStore.Unset(ctx, permission.UserID(ctx), input.Target)
+		err = a.FavoriteStore.Unset(ctx, a.DB, permission.UserID(ctx), input.Target)
 	}
 
 	if err != nil {

graphql2/graphqlapp/rotation.go

@@ -51,7 +51,7 @@ func (m *Mutation) CreateRotation(ctx context.Context, input graphql2.CreateRota
 		}
 
 		if input.Favorite != nil && *input.Favorite {
-			err = m.FavoriteStore.SetTx(ctx, tx, permission.UserID(ctx), assignment.RotationTarget(result.ID))
+			err = m.FavoriteStore.Set(ctx, tx, permission.UserID(ctx), assignment.RotationTarget(result.ID))
 			if err != nil {
 				return err
 			}

graphql2/graphqlapp/schedule.go

@@ -248,7 +248,7 @@ func (m *Mutation) CreateSchedule(ctx context.Context, input graphql2.CreateSche
 			return err
 		}
 		if input.Favorite != nil && *input.Favorite {
-			err = m.FavoriteStore.SetTx(ctx, tx, permission.UserID(ctx), assignment.ScheduleTarget(sched.ID))
+			err = m.FavoriteStore.Set(ctx, tx, permission.UserID(ctx), assignment.ScheduleTarget(sched.ID))
 			if err != nil {
 				return err
 			}

graphql2/graphqlapp/service.go

@@ -157,7 +157,7 @@ func (m *Mutation) CreateService(ctx context.Context, input graphql2.CreateServi
 		}
 
 		if input.Favorite != nil && *input.Favorite {
-			err = m.FavoriteStore.SetTx(ctx, tx, permission.UserID(ctx), assignment.ServiceTarget(result.ID))
+			err = m.FavoriteStore.Set(ctx, tx, permission.UserID(ctx), assignment.ServiceTarget(result.ID))
 			if err != nil {
 				return err
 			}

graphql2/graphqlapp/user.go

@@ -165,7 +165,7 @@ func (a *Mutation) CreateUser(ctx context.Context, input graphql2.CreateUserInpu
 			return err
 		}
 		if input.Favorite != nil && *input.Favorite {
-			err = a.FavoriteStore.SetTx(ctx, tx, permission.UserID(ctx), assignment.UserTarget(newUser.ID))
+			err = a.FavoriteStore.Set(ctx, tx, permission.UserID(ctx), assignment.UserTarget(newUser.ID))
 			if err != nil {
 				return err
 			}

sqlc.yaml

@@ -24,6 +24,7 @@ sql:
       - engine/statusmgr/queries.sql
       - auth/authlink/queries.sql
       - alert/alertlog/queries.sql
+      - user/favorite/queries.sql
       - user/contactmethod/queries.sql
       - integrationkey/queries.sql
       - apikey/queries.sql

user/favorite/queries.sql

@@ -0,0 +1,37 @@
+-- name: UserFavSet :exec
+INSERT INTO user_favorites(user_id, tgt_service_id, tgt_schedule_id, tgt_rotation_id, tgt_escalation_policy_id, tgt_user_id)
+    VALUES ($1, $2, $3, $4, $5, $6)
+ON CONFLICT
+    DO NOTHING;
+
+-- name: UserFavUnset :exec
+DELETE FROM user_favorites
+WHERE user_id = $1
+    AND tgt_service_id = $2
+    OR tgt_schedule_id = $3
+    OR tgt_rotation_id = $4
+    OR tgt_escalation_policy_id = $5
+    OR tgt_user_id = $6;
+
+-- name: UserFavFindAll :many
+SELECT
+    tgt_service_id,
+    tgt_schedule_id,
+    tgt_rotation_id,
+    tgt_escalation_policy_id,
+    tgt_user_id
+FROM
+    user_favorites
+WHERE
+    user_id = @user_id
+    AND ((tgt_service_id NOTNULL
+            AND @allow_services::bool)
+        OR (tgt_schedule_id NOTNULL
+            AND @allow_schedules::bool)
+        OR (tgt_rotation_id NOTNULL
+            AND @allow_rotations::bool)
+        OR (tgt_escalation_policy_id NOTNULL
+            AND @allow_escalation_policies::bool)
+        OR (tgt_user_id NOTNULL
+            AND @allow_users::bool));
+