Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integration keys sqlc #3293

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Conversation

andrewbenington
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Migrated all integration key SQL statements to use sqlc. Also modified UUID validation to optionally return the parsed UUIDs.

Which issue(s) this PR fixes:
Part of #3235

Out of Scope:
Include any out of scope items here.

Screenshots:
If applicable, add some screenshots here.

Describe any introduced user-facing changes:
If introducing any user-facing changes, provide a clear description of them.

Describe any introduced API changes:
If introducing any API changes, provide a clear description of them.

Additional Info:
Any additional information or context.

@andrewbenington andrewbenington changed the title Chore integration keys sqlc chore: integration keys sqlc Sep 20, 2023
integrationkey/queries.sql Outdated Show resolved Hide resolved
integrationkey/store.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@allending313 allending313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrewbenington andrewbenington merged commit 4cad934 into master Sep 20, 2023
6 checks passed
@andrewbenington andrewbenington deleted the chore--integration-keys-sqlc branch September 20, 2023 21:14
allending313 pushed a commit that referenced this pull request Sep 27, 2023
* integration key sqlc queries

* remove statement preparation

* tidy up queries

* require db/tx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants