Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apikey: allow copy as JSON and fix query formatting #3434

Merged
merged 2 commits into from
Nov 16, 2023
Merged

apikey: allow copy as JSON and fix query formatting #3434

merged 2 commits into from
Nov 16, 2023

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Nov 8, 2023 •
edited by Forfold
Loading

Description:
This PR improves the UX of the Show Query dialog when viewing API keys.

  • Fixed formatting of the query text
  • Adds the ability to copy as JSON so it can be pasted directly into code or a debugging tool

Additional changes:

  • Updates <CopyText /> to use Typography instead of a span. This resolves issues we have intermittently seen such as Cannot have <p> be a child of <span>

Screenshots:

screenshot_2023-11-13_at_1 59 34_pm_360

screenshot_2023-11-13_at_1 54 21_pm

screenshot_2023-11-13_at_1 54 32_pm

@mastercactapus mastercactapus marked this pull request as ready for review November 14, 2023 16:16
@m17ch m17ch merged commit 6f99b57 into master Nov 16, 2023
9 checks passed
@m17ch m17ch deleted the show-query-ux branch November 16, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m17ch m17ch m17ch approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @Forfold @m17ch