Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/urql: convert user lists to urql #3495

Merged
merged 5 commits into from
Nov 30, 2023
Merged

ui/urql: convert user lists to urql #3495

merged 5 commits into from
Nov 30, 2023

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Migrates from @apollo/client to urql for the following files:

  • web/src/app/users/UserCalendarSubscriptionList.tsx
  • web/src/app/users/UserList.tsx
  • web/src/app/users/UserOnCallAssignmentList.tsx
  • web/src/app/users/UserSessionList.tsx

Which issue(s) this PR fixes:
Part of #3240

@mastercactapus mastercactapus merged commit 0335dc7 into master Nov 30, 2023
7 checks passed
@mastercactapus mastercactapus deleted the user-lists-urql branch November 30, 2023 23:06
@KatieMSB KatieMSB mentioned this pull request Dec 5, 2023
Open
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@mastercactapus mastercactapus mastercactapus approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @Forfold