ui/schedules: convert ScheduleRuleList, ScheduleRuleCreateDialog, ScheduleRuleEditDialog to typescript #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
reviewed
Dec 12, 2023
Forfold
reviewed
Dec 12, 2023
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
…schedulerulelist_ts
Forfold
previously approved these changes
Dec 29, 2023
76 tasks
tony-tvu
changed the title
Forfold
approved these changes
Jan 10, 2024
KatieMSB
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Converts
ScheduleRuleEditDialog,ScheduleRuleListandScheduleRuleCreateDialogto use typescript and urql.Which issue(s) this PR fixes:
Part of #2318 and #3240