-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add label chips to service details #3530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think below the escalation policy is a good placement for it, but perhaps we should put it under the icon? that way it won't feel as constrained to fit, and wrapping won't be an issue if multiple labels are present
@Forfold, I moved them to their own section in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Forfold, that would be great, ty :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
This PR adds chips on the service details page for configured labels.
Which issue(s) this PR fixes:
Part of #3425
Screenshots:
Describe any introduced user-facing changes:
Service details page will now display any labels under the escalation policy.
Describe any introduced API changes:
N/A