Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label chips to service details #3530

Merged
merged 5 commits into from
Jan 8, 2024
Merged

add label chips to service details #3530

merged 5 commits into from
Jan 8, 2024

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Dec 12, 2023

Description:
This PR adds chips on the service details page for configured labels.

Which issue(s) this PR fixes:
Part of #3425

Screenshots:
image

Describe any introduced user-facing changes:
Service details page will now display any labels under the escalation policy.

Describe any introduced API changes:
N/A

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think below the escalation policy is a good placement for it, but perhaps we should put it under the icon? that way it won't feel as constrained to fit, and wrapping won't be an issue if multiple labels are present

@mastercactapus
Copy link
Member Author

@Forfold, I moved them to their own section in the DetailsPage component. It seemed fitting since other types will be adopting labels in the future, too.

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things related to padding, can we:

  • Reduce the bottom/top padding of the description text, and
  • Add padding to the chips (maybe put in a grid?)

I can push this up if you want!

Screenshot 2023-12-26 at 8 20 51 PM

@mastercactapus
Copy link
Member Author

@Forfold, that would be great, ty :)

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the updated padding:

Screenshot 2023-12-28 at 9 07 19 AM

LGTM!

@Forfold Forfold merged commit e5d3fbc into master Jan 8, 2024
7 checks passed
@Forfold Forfold deleted the show-labels-on-services branch January 8, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants