Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: convert user contact method .js dependencies to .jsx #3652

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Feb 5, 2024

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This pull request addresses an issue related to storybook component tests encountering errors caused by dependencies in UserContactMethodForm, UserContactMethodCreateDialog, and UserContactMethodEditDialog relying on .js files. To resolve this, all dependencies for UserContactMethod have been converted to use the .jsx file format. It's important to note that there are no actual code modifications within these files.

Storybook error this PR address:
Screenshot 2024-02-05 at 12 32 47 PM

Which issue(s) this PR fixes:
Part of #2639

Out of Scope:
N/A

Screenshots:
N/A

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:
N/A

Additional Info:
N/A

@tony-tvu tony-tvu merged commit 68c2cf1 into master Feb 6, 2024
7 checks passed
@tony-tvu tony-tvu deleted the js-to-jsx branch February 6, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants