Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type universal to integration keys #3836

Merged
merged 10 commits into from
May 3, 2024
Merged

add type universal to integration keys #3836

merged 10 commits into from
May 3, 2024

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented May 2, 2024

Description:
Adds type universal to integration keys, as well as everywhere else key types are used.

Which issue(s) this PR fixes:
Unsure

Out of Scope:
Href value

Forfold
Forfold commented May 2, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@github-actions github-actions bot added the size/s label May 2, 2024
@Forfold
Copy link
Contributor Author

Forfold commented May 2, 2024

Do I need to put this behind an experimental flag @mastercactapus? Seems like there's quite a few places where it's being introduced (types, sources, schema, and hard coded in the wizard UI)

mastercactapus
mastercactapus requested changes May 2, 2024
View reviewed changes
Copy link
Member

@mastercactapus mastercactapus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Forfold

  • Anything listing keys should hide "universal" unless the exp flag is set (this should be automatic in the UI useFeatures().integrationKeyTypes
  • Creating an integration key should guard against the Universal type unless the exp flag is set

graphql2/graphqlapp/config.go Outdated Show resolved Hide resolved
migrate/migrations/20240502114803-universal-integration-key.sql Show resolved Hide resolved
web/src/app/wizard/WizardForm.jsx Outdated Show resolved Hide resolved
web/src/app/admin/admin-service-metrics/AdminServiceFilter.tsx Outdated Show resolved Hide resolved
web/src/app/wizard/utilTestData.js Outdated Show resolved Hide resolved
web/src/cypress/support/service.ts Outdated Show resolved Hide resolved
mastercactapus
mastercactapus requested changes May 2, 2024
View reviewed changes
graphql2/graphqlapp/config.go Outdated Show resolved Hide resolved
integrationkey/store.go Outdated Show resolved Hide resolved
Forfold and others added 4 commits May 2, 2024 13:18
@Forfold @mastercactapus
update universal key label
55e6b8c 
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
@Forfold @mastercactapus
update exp flag check for universal keys
380386b 
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
@Forfold
add import
80bd2f5
@Forfold
make check
d424002
@mastercactapus mastercactapus merged commit ddd62b0 into master May 3, 2024
7 checks passed
@mastercactapus mastercactapus deleted the uni-key-add branch May 3, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allending313 allending313 allending313 approved these changes

@mastercactapus mastercactapus mastercactapus approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Forfold @mastercactapus @allending313