Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/list: padding and console fixes #3850

Merged
merged 5 commits into from
May 8, 2024
Merged

ui/list: padding and console fixes #3850

merged 5 commits into from
May 8, 2024

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented May 7, 2024

  • Adjust padding of External Keys summary and list items to match page
  • Updates summary open/close icon to match rest of app
  • Removes divider above external keys
  • Fixes several errors in the warning, such as:
    • <p> must not be a child of <p>
    • <div> must not be a child of <p>
    • <a> must not be a child of <a>
    • Functional components cannot be given refs, did you mean to use forwardRef?

@github-actions github-actions bot added the size/s label May 7, 2024
allending313
allending313 previously approved these changes May 8, 2024
@Forfold Forfold merged commit 9ef6b8f into master May 8, 2024
7 checks passed
@Forfold Forfold deleted the ext-keys-fixes branch May 8, 2024 18:22
allending313 pushed a commit that referenced this pull request Jul 2, 2024
* adjust padding, update icon, remove divider

* fix incredibly annoying console errors

* remove AppLinkListItem in favor of li

* add better comment, fix console error

* render links as anchors

---------

Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants