-
Notifications
You must be signed in to change notification settings - Fork 69
Conversation
3b1da5c
to
2541e94
Compare
PTAL |
One thing that is currently missing is a link from the top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that we can simplify the setup so much with the new modules!
If we delete the tutorial, there is no “hand holding”-style section anymore that the user can follow step-by-step. I think demonstrating the basic features in a tutorial is still a good thing, and even though we integrate the setup part into the readme, the demo itself is missing after. With the simplfied setup, we should have even more space to demonstrate the cool capabilities lorri has, so maybe that should be a followup quest, make another tutorial.
README.md
Outdated
@@ -14,96 +14,135 @@ external dependencies, editor integration, and quick feedback. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the tutorial I had this paragraph:
This gives you `nix` editor integration for free. Whenever you open
a file, as long as there is a `direnv`/`lorri` setup in the project,
your editor automatically loads all tools, environment variables,
library dependencies, etc. from your nix files. In short: Everything
you need to be productive on your project and everything to make sure
your codevelopers have the same, reproducible setup.
Even further, if you change something in your nix files, `lorri`
immediately picks it up, and your editor does as well.
Can we salvage some of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use a pretty vanilla Vim setup for most of my coding.
your editor automatically loads all tools, environment variables,
library dependencies, etc. from your nix files.
This just isn't really true for example for my development experience. Whether I'm inside or outside a direnv
directory has no impact on my editor at all, except that other command line tools are available via :! <tool>
.
However, I do think that users (including me) can probably benefit from learning about how to integrate their editor(s) with direnv
for a better development experience. This is why I wanted to keep the "How to integrate with Emacs" tutorial (tentatively in contrib/EMACS.md
), and I think there should be a prominent link to it from the top-level README (see #233 (comment)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a chance that because I haven't made an effort to customise my development experience based on per-project direnv
/ lorri
things, I'm underestimating the importance of the customisation possibilities that come with the direnv
/ lorri
duo.
If you would like the messaging to go more in this direction, I'm happy to oblige - in that case, there should be at least a teaser about editor customisation directly in the top-level README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just isn't really true for example for my development experience. Whether I'm inside or outside a
direnv
directory has no impact on my editor at all, except that other command line tools are available via:! <tool>
.
You are missing out very much. Good editor tooling support is a base premise of lorri and improves productivity significantly in my experience.
The paragraph was from back when it was Emacs-specific, but we should strongly recommend users to set up editor tooling, because lorri makes it often possible in the first place.
I'm underestimating the importance of the customisation possibilities that come with the
direnv
/lorri
duo.
yeah! try it out :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can show you some of the stuff I use if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a stub "Editor integration" section with a link to contrib/emacs.md
and #244 as a follow-up to flesh this out more.
41cac41
to
0539bea
Compare
Okay, a few more comments, then we are ready to merge. |
LGTM |
Closes #225, #226, #227, #231.
Motivation
We currently have the top-level
README.md
andexample/README.md
andcontrib/README.md
. My proposal is this:lorri
users, with explicit requirements, in the top-levelREADME.md
lorri
on other systems, with additional files to help the process along, incontrib
.To actually use
lorri
, the following are required:direnv
must be installed and enabledlorri
must be installed and the daemon must be running.envrc
that invokeslorri direnv
The idea here is that for people using either NixOS or
home-manager
and a Nix channel that is at least as recent asnixos-19.09
, this is really easy. I believe that a lot oflorri
users meet these requirements, so I think that it would make sense to optimise the "README experience" for those users.Changes
README.md
in a way that guides users who meet the requirements above through the fast pathcontrib
) in the "Install" and "Usage" sections of the top-levelREADME.md
example/README.md
, put it intocontrib/
and link to it from the top-levelREADME.md
, then remove the remainder of theexample/
directoryAt this point, the
example/README.md
will no longer be necessary since all the information in here should now be contained in the top-levelREADME.me
in a streamlined form.Previews