Skip to content

Commit

Permalink
test: show child stderr output in largepages test
Browse files Browse the repository at this point in the history
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: nodejs#31547 (comment)

PR-URL: nodejs#31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
bnoordhuis authored and targos committed Apr 25, 2020
1 parent 9690a53 commit 443610d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/parallel/test-startup-large-pages.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ const { spawnSync } = require('child_process');

{
const child = spawnSync(process.execPath,
[ '--use-largepages=on', '-p', '42' ]);
[ '--use-largepages=on', '-p', '42' ],
{ stdio: ['inherit', 'pipe', 'inherit'] });
const stdout = child.stdout.toString().match(/\S+/g);
assert.strictEqual(child.status, 0);
assert.strictEqual(child.signal, null);
Expand Down

0 comments on commit 443610d

Please sign in to comment.