-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows_compatibility_tari_base_node #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will set aside some time to dig deeper into this - LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
P.S. Great PR description!
Squash the commits please |
b05f52e
to
1d8270b
Compare
…layer to be added for Windows builds. This removes `store_forward` functionality from Windpows, but provides a temporary fix. - Small refactoring for `fn load_users()` in `lmdb.rs` - Windows build and run instructions where SQLite is a dependency Signed-off-by: Hansie Odendaal <pluto@tari.com>
1d8270b
to
2b75d32
Compare
At least 2x more PRs will be needed after this one:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
store_forward
Tokio layer to be added for Windows builds. This removesstore_forward
functionality from Windpows, but provides a temporary fix.fn load_users()
inlmdb.rs
Motivation and Context
The
tari_base_node
creates a stack overflow error when run in Windows. This has been traced to the implementation of multiple Tokio layers inpub fn inbound_middleware_layer
(compliments due to @sdbondi). Excluding the 2xstore_forward
Tokio layers works for now. It seems this problem is related to the amount of layers added as well.How Has This Been Tested?
The
tokio::runtime::Builder::new().thread_stack_size
has been increased from 2MB to 200MB but this did not solve the problem.Conditional compilation fully tested in Windows and Ubuntu Linux with
cargo test
tari_base_node
was run and left to mine blocks on Windows and Ubuntu Linux; both mine successfully.Windows
Ubuntu Linux
Types of changes
Checklist:
development
branchcargo-fmt --all
before pushing