feat!: implement inflating tail emission #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
CR-insufficient_context
CjS77
changed the title
CjS77
added
A-base_node
Test Results (CI)1 259 tests 1 259 ✅ 11m 53s ⏱️ Results for commit ec1245e. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files + 2 11 suites +11 14m 43s ⏱️ + 14m 43s For more details on these failures, see this check. Results for commit ec1245e. ± Comparison against base commit f5860a8. ♻️ This comment has been updated with latest results. |
SWvheerden
previously approved these changes
Feb 21, 2024
| @@ -119,7 +119,7 @@ message ConsensusConstants { | |||
| uint64 median_timestamp_count = 9; | |||
| uint64 emission_initial = 10; | |||
| repeated uint64 emission_decay = 11; | |||
| uint64 emission_tail = 12; | |||
| uint64 emission_tail = 12 [deprecated=true]; | |||
There was a problem hiding this comment.
Nit:
I think we can just delete this, it should default to 0 if you ask for it in a dated proto file.
But I am 99% nothing uses this field
There was a problem hiding this comment.
Let's nuke it in a separate PR so that it's easy to revert if you're wrong.
ghpbot-tari-project
removed
the
P-reviews_required
CjS77
force-pushed
the
Refactor-emission-schedule
branch
2 times, most recently
from
9de36db
to
bf98053
Compare
ghpbot-tari-project
added
the
P-reviews_required
Adds a feature `tari_feature_mainnet_emission` to allow for tail emission inflation. See #6122 This change necessitates the addition of 2 new consensus constants: `inflation_bips` -- the annual inflation rate of the total supply in basis points (100 bips = 1 percentage point). and `tail_emission_epoch_length`, which controls the tail emission inflation. These replace `tail_emission`. We update the Protobuf definition for `ConsensusConstants` to account for the new fields. Updates tests Adds `as_u128` to `MicroMinotari` since we need to perform a large multiplication when calculating the inflation issuance. Note: Replaces part of #6131
CjS77
force-pushed
the
Refactor-emission-schedule
branch
from
bf98053
to
1e8ca53
Compare
Closed
SWvheerden
approved these changes
Feb 28, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a feature
tari_feature_mainnet_emissionto allow for tail emissioninflation. See #6122
This change necessitates the addition of 2 new consensus constants:
inflation_bips-- the annual inflation rate of the total supply.and
tail_emission_epoch_length, which controls the tail emissioninflation. These replace
tail_emission.We update the Protobuf definition for
ConsensusConstantsto account forthe new fields.
Note: Replaces part of #6131