Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change split to 50-50 #6188

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Mar 6, 2024

Description

Change the algo split to 50-50

Motivation and Context

Change the split not to favor any algorithm. Having the split not be exactly 50-50, it slightly favors the less one if they arrive within the same block period.

Fixes: #6187

@SWvheerden SWvheerden requested a review from a team as a code owner March 6, 2024 11:43
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Test Results (CI)

    3 files    120 suites   36m 37s ⏱️
1 268 tests 1 268 ✅ 0 💤 0 ❌
3 796 runs  3 796 ✅ 0 💤 0 ❌

Results for commit 71b2504.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 6, 2024

Test Results (Integration tests)

29 tests  +29   29 ✅ +29   12m 0s ⏱️ + 12m 0s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 71b2504. ± Comparison against base commit 4821660.

♻️ This comment has been updated with latest results.

hansieodendaal
hansieodendaal previously approved these changes Mar 6, 2024
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 6, 2024
@ghpbot-tari-project ghpbot-tari-project added the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 11, 2024
@SWvheerden SWvheerden merged commit 3b7842a into tari-project:development Mar 11, 2024
15 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_change_split branch March 11, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change coin split to 50-50
3 participants