feat!: new tari address scheme #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (Integration tests) 2 files 11 suites 23m 0s ⏱️ For more details on these failures, see this check. Results for commit 2872f71. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 120 suites 42m 29s ⏱️ For more details on these failures, see this check. Results for commit 2872f71. ♻️ This comment has been updated with latest results. |
brianp
reviewed
May 23, 2024
ghpbot-tari-project
added
the
CR-too_long
SWvheerden
changed the title
SWvheerden
changed the title
SWvheerden
force-pushed
the
sw_tari_address
branch
from
fb061b8
to
dc80584
Compare
base_layer/wallet/src/utxo_scanner_service/uxto_scanner_service_builder.rs
Outdated
Show resolved
Hide resolved
SWvheerden
added a commit
that referenced
this pull request
May 28, 2024
Description --- split message to have dedicated to and from fields Motivation and Context --- This is needed for #6353 When a chat client receives a message, it needs to know the complete address of the receiver, not just a part of it. This allows the user to get the complete address by saving what the sender said their address is --------- Co-authored-by: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com>
Co-authored-by: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com>
SWvheerden
force-pushed
the
sw_tari_address
branch
from
a04fbac
to
ebba5f2
Compare
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the tari address scheme to support view keys and spend keys.
Makes network and features human-readable
Motivation and Context
This allows Tari to support stealth one-sided transactions via Hardware devices.
Makes features and network human readable.
How Has This Been Tested?