Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added basic async request-reply handle for #654 #657

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Added basic async request-reply handle for #654 #657

merged 1 commit into from
Aug 8, 2019

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 7, 2019 •
edited
Loading

Description

ChannelServiceHandle should be the most commonly used
handle for a service. It is used to send requests
on a given unbounded mpsc sender and produce a future which
should resolve to a response.

Motivation and Context

Ref #654

How Has This Been Tested?

Unit tests (added dev-dependency tokio_mock_task)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch
  • I ran cargo-fmt --all before pushing
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@sdbondi
Added basic async request-reply handle for future use
d14cb1a 
`ChannelServiceHandle` should be the most commonly used
handle for a service. It is used to send requests
on a given unbounded mpsc sender and produce a future which
should resolve to a response.
@sdbondi sdbondi changed the title Added basic async request-reply handle for #620 Added basic async request-reply handle for #654 Aug 7, 2019
neonknight64
neonknight64 approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@neonknight64 neonknight64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CjS77 CjS77 merged commit d14cb1a into development Aug 8, 2019
CjS77 added a commit that referenced this pull request Aug 8, 2019
@CjS77
Added basic async request-reply handle for future use (#657)
b6cea15 
Merge pull request #657

ChannelServiceHandle should be the most commonly used
handle for a service. It is used to send requests
on a given unbounded mpsc sender and produce a future which
should resolve to a response.
@CjS77 CjS77 deleted the sb-services-handle branch August 8, 2019 11:29
@sdbondi sdbondi mentioned this pull request Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonknight64 neonknight64 neonknight64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdbondi @neonknight64 @CjS77