fix: coinbase padding #1242
Merged
fix: coinbase padding #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalazsSevecsek
force-pushed
the
fix/coinbase
branch
from
b323479 to
416ee5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
coinbase '=' padding character caused an issue where an alternative string was written to the blockchain
Motivation and Context
Invalid id written to the chain.
How Has This Been Tested?
On esmeralda with a local build.
What process can a PR reviewer use to test or verify this change?
Check the coinbase extra string that gets written to the block and compare that to what the merge mining proxy gets as an arg.
Breaking Changes