Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune-release opam submit uses synopsis of a random opam package #265

Open
hannesm opened this issue Aug 8, 2020 · 2 comments
Open

dune-release opam submit uses synopsis of a random opam package #265

hannesm opened this issue Aug 8, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@hannesm
Copy link
Contributor

hannesm commented Aug 8, 2020

When I dune-release opam submit in the ocaml-tls (https://github.com/mirleft/ocaml-tls) repository, the generated PR contains the synopsis of the tls-mirage opam package, though I'd prefer it to contain the contents from the tls opam package. see ocaml/opam-repository#16984

I think there's a general issue with multiple opam packages in a single repository (see #244). I'd suggest to denote a "main" opam package (and as I understand, this is the one without -: irmin in the https://github.com/mirage/irmin repository, dns in https://github.com/mirage/ocaml-dns, dune in https://github.com/ocaml/dune, tls in https://github.com/mirleft/ocaml-tls) which content (synopsis, homepage, etc.) is used where needed.

I know #249 has been merged which likely modifies the behaviour slightly (though not clear to me whether this is good now). I used dune-release 1.4.0 here.

@hannesm
Copy link
Contributor Author

hannesm commented Aug 8, 2020

..or use the data in dune-project..

@gpetiot
Copy link
Member

gpetiot commented Aug 8, 2020

Using the data in dune-project can be a stable solution, I will have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants