Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort package names alphabetically in Opam PR #249

Closed
craigfe opened this issue Jul 13, 2020 · 2 comments · Fixed by #263
Closed

Sort package names alphabetically in Opam PR #249

craigfe opened this issue Jul 13, 2020 · 2 comments · Fixed by #263

Comments

@craigfe
Copy link
Contributor

craigfe commented Jul 13, 2020

When releasing multiple packages at once, dune-release seems to pick an arbitrary order for the package names in the release. For instance:

[new release] alcotest-lwt, alcotest, alcotest-async and alcotest-mirage (1.2.0)
Open • CraigFe wants to merge 1 commit into master from release-alcotest-1.2.0


  Lwt-based helpers for Alcotest

  • Project page: https://github.com/mirage/alcotest
  • Documentation: https://mirage.github.io/alcotest

  ##### CHANGES:

When it does this, it constructs the PR description from the first package in the list. It'd be good to have some way of giving dune-release either a file from which to take the description (à la hub pull-request -F <FILE>), or to tell it that one particular package is the "canonical" one and should always appear first. (The latter would suffice for all of the projects I regularly release.)

@craigfe
Copy link
Contributor Author

craigfe commented Jul 13, 2020

After some further thought, it also seems fine for dune-release to just not try to find a package description when there are multiple in the repository.

@NathanReb
Copy link
Contributor

I wonder if we haven't fixed that already on master. I remember another issue on this topic, I'll take a look.

Sorting seems fine indeed, I wonder if there isn't already some logic to use the shortest name as the "main package" name.

I also agree it should be fine not to include the description when releasing several packages at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants