Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check command #318

Merged
merged 5 commits into from
Mar 18, 2021
Merged

Add check command #318

merged 5 commits into from
Mar 18, 2021

Commits on Mar 17, 2021

  1. Remove use of cli distrib_uri in publish 

    The command line argument `distrib_uri` has two purposes
- for delegates
- to let dune-release in `dune-relesae opam` know where the distribution
tarball is on the web when having published the distribution independently

Furthermore, `dune-release publish` needs to know on which github url
to publish the release. Therefore it inferres the user and repo name from
the dev-repo url. Before this commit, the user and repo name were instead
inferred from the `distrib_uri` when provided, assuming that it is the
standard release uri of a github realease without checking that. This
commit removes this use of `ditrib_uri`.
    @pitag-ha
    pitag-ha committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    55eb0db View commit details
    Browse the repository at this point in the history

  2. Lint summary: mention name of the linted package 

    Only mentioning the directory of the project is misleading, since the lint
doesn't only check if the standard files in the directory exist, but also
lints the opam file of the package. Before this commit, in multi pckage
projects, the lint summary statement for every package was the same - only
the number of lint errors possibly changed.
    @pitag-ha
    pitag-ha committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    c0d590e View commit details
    Browse the repository at this point in the history

  3. Improve build/test logging 

    Writing "package" in singular misleads into thinking that only the main
package gets checked for build and tests, whereas in fact either all
packages or all packages passed in via `-p` are checked.

Particularly for the `check` command it's important to be precise here,
since in that command some checks are done just for the main package and
others for all packages.
    @pitag-ha
    pitag-ha committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    61945ef View commit details
    Browse the repository at this point in the history

  4. Add a check command 

    The new check command allows the user to make sure that the whole release
process will be smooth: it checks if the opam-file is dune-release compatible
and - unless stated otherwise by the
user via the skip options - performs the checks that will be done on the
distribution archive: if it builds, if it passes its tests and if it
passes the dune-release lints. For all that, the same options are taken
into account as will be when releasing.
    @pitag-ha
    pitag-ha committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    701b799 View commit details
    Browse the repository at this point in the history

  5. Separate lints for different packages via logging

    @pitag-ha
    pitag-ha committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    2dc5e9b View commit details
    Browse the repository at this point in the history