Rename "repo" to "root" #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
reviewed
Oct 22, 2021
samoht
force-pushed
the
root
branch
2 times, most recently
from
40e3340
to
b06a3fc
Compare
|
Updated with a CHANGELOG entry. |
The current terminology is a bit confusing, this option is actually used to define the project root (or workspace root).
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
approved these changes
Oct 22, 2021
Merged
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Nov 23, 2021
CHANGES: ### Added - Add a list subcommand to list the duniverse packages in the lockfile (tarides/opam-monorepo#217, @samoht) ### Changed - Only warn users about missing dune-ports repo in OPAM switch if no solution can be found due to packages not building with dune (tarides/opam-monorepo#210, @Leonidas-from-XIV) - Rename the `--repo` option to `--root` to make it more straightforward that this is referring to the project root (tarides/opam-monorepo#218, @samoht) - Improve the wording of the lockfile selection log (tarides/opam-monorepo#222, @NathanReb) - Display the full solver error with `--verbose` (tarides/opam-monorepo#229, @emillon) ### Fixed - Better errors for `opam-monorepo depext`, especially for non-interactive shells (tarides/opam-monorepo#216, @samoht) - Properly detect all opam packages defined in the current repository, preventing it from later pulling duplicates into the duniverse if they were part of the target packages dependencies. (tarides/opam-monorepo#203, @Leonidas-from-XIV) - Properly report missing dune-project file when trying to determine the to-be-genrated lockfile name (tarides/opam-monorepo#227, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current terminology is a bit confusing, this option is actually used
to define the project root (or workspace root).