Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where opam-provided CLI options would be ignored #314

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

NathanReb
Copy link
Contributor

No description provided.

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
… CLI args ignored

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
@NathanReb
Copy link
Contributor Author

I'll cut a release with this in!

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@NathanReb NathanReb requested a review from tmattio June 10, 2022 15:14
Copy link
Member

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this all looks sensible to me. Thanks!

@NathanReb NathanReb merged commit 668aaab into tarides:main Jun 13, 2022
@NathanReb NathanReb deleted the fix-opam-provided-cli-ignored branch June 13, 2022 08:31
NathanReb added a commit to NathanReb/opam-repository that referenced this pull request Jun 13, 2022
CHANGES:

### Fixed

- Fix a bug that caused `--add-opam-provided` and `--opam-provided` to be
  ignored by the solver. (tarides/opam-monorepo#314, @NathanReb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants