-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of lock files with empty duniverses #321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, the code looks quite elegant. I'm only slightly worried about the fragility of a test, but that's more for ill-defined portability reasons.
54c1d84
to
e583ffc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, let's get it in for the next release!
Looks like my merge of the bugfix created a changelog conflict, sorry about that. |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
6eca09f
to
82026ad
Compare
My bad, forgot to merge after the review! Just rebased and fixed the conflict, will merge when it goes green! |
CHANGES: ### Added - Add support for specifying remote URLs in `x-opam-monorepo-repositories` (tarides/opam-monorepo#284, tarides/opam-monorepo#317, @Leonidas-from-XIV) ### Fixed - Enable locking of packages with depexts even with uninitialized system package manager state (tarides/opam-monorepo#322, @Leonidas-from-XIV) - Fix a bug where `pull` would crash if the lock file contained no package to vendor (tarides/opam-monorepo#321, @NathanReb) - Display a better error message when the depext command fails when getting the status of the packages (tarides/opam-monorepo#258, tarides/opam-monorepo#323, @RyanGibb, @Julow) - Take `archive-mirrors` from the global opam configuration into account to allow more local caches (tarides/opam-monorepo#337, @hannesm) - Log at WARN level when opam-monorepo chooses a source for a package that doesn't match the package's version (tarides/opam-monorepo#352, @reynir)
Fixes #319