-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand gc-stats help #28
Conversation
What more can be added to this? I guess examples from the README needs to be. We shouldn't be adding them as such, right? |
bin/olly.ml
Outdated
@@ -345,7 +345,7 @@ let () = | |||
`Blocks help_secs; | |||
] | |||
in | |||
let doc = "Report the GC latency profile and stats." in | |||
let doc = "Report the GC latency profile and stats. Total time spent by the program performing garbage collection (major and minor)" in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ju-sh! You can possibly add the metrics and descriptions mentioned here: https://github.com/tarides/runtime_events_tools#gc-stats
This reverts commit 7f8ca6e.
Copy-pasted some info from README to gc-stats subcommand's help message.
Is it better? |
Thanks! This looks good to me. |
CHANGES: * Fix support on ARM64 platforms (Linux and MacOS) (tarides/runtime_events_tools#34, @tmcgilchrist) * Remove ocamlfind dependency. (tarides/runtime_events_tools#36, @tmcgilchrist) * Expand gc-stats help (tarides/runtime_events_tools#28, @ju-sh)
Add information about gc-stats to --help command, using information already present in the README.
Made as part of OCaml hack event at Chennai on Oct 21st.
With help from Siva.