Restructuring Benchmarks #3
Conversation
|
Warning Rate limit exceeded@madflojo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 30 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates focus on enhancing benchmarking functionality across various database drivers. The primary changes involve altering benchmark execution paths and introducing new GitHub Actions steps for handling benchmark data. Benchmarking functions have been newly implemented or updated in drivers for Changes
Sequence Diagram(s)No sequence diagrams are necessary for these changes, as they involve routine additions and adjustments to benchmarking code. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 19
Outside diff range and nitpick comments (3)
drivers/redis/benchmark_test.go (3)
54-54: Improve error messages.Include context in the error message to make debugging easier.
- b.Fatalf("Got unexpected error when connecting to Redis - %s", err) + b.Fatalf("Got unexpected error when connecting to Redis (%s) - %s", datastore, err)
68-68: Improve error messages.Include context in the error message to make debugging easier.
- b.Fatalf("Error while checking health of DB - %s", err) + b.Fatalf("Error while checking health of DB (%s) - %s", datastore, err)
111-113: Improve error messages.Include context in the error message to make debugging easier.
- b.Fatalf("Error when executing Benchmark test - %s", err) + b.Fatalf("Error when executing Benchmark test (%s) - %s", datastore, err)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
benchmarks/go.sumis excluded by!**/*.sum
Files selected for processing (6)
- .github/workflows/benchmarks.yml (6 hunks)
- drivers/bbolt/benchmark_test.go (1 hunks)
- drivers/cassandra/benchmark_test.go (1 hunks)
- drivers/hashmap/benchmark_test.go (1 hunks)
- drivers/nats/benchmark_test.go (1 hunks)
- drivers/redis/benchmark_test.go (1 hunks)
Additional comments not posted (1)
drivers/redis/benchmark_test.go (1)
1-120: LGTM!The function is well-structured and includes comprehensive benchmarking for Redis, Dragonfly, and KeyDB datastores.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/benchmarks.yml (7 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/benchmarks.yml
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This pull request removes the generic Benchmarks module and moves all the benchmarks into their respective driver locations.
As I split each driver into its own module, a massive benchmark module doesn't make sense, as it would complicate validating benchmark results.
Summary by CodeRabbit