style: fixing linter errors

[madflojo]

This pull request fixes some recently found linter errors.

Summary by CodeRabbit

• Refactor
  • Improved HTTP request handling within middleware setup for enhanced performance.
• Tests
  • Simplified test functions across various modules by removing unused parameters, making the tests cleaner and easier to understand.

[coderabbitai]

Walkthrough

The recent updates focus on refining the codebase by eliminating unused parameters in functions across various modules. This cleanup effort enhances readability and simplifies the code by removing unnecessary clutter. These adjustments span from server request handling to testing suites, indicating a broad effort to streamline the code for efficiency and clarity.

Changes

Files	Change Summary
pkg/app/server.go	Removed ps httprouter.Params from anonymous function in handlerWrapper within Server struct.
.../callbacks_test.go & .../telemetry/telemetry_test.go	Replaced function parameters with _ in test functions to indicate unused parameters.
.../kvstore/kvstore_test.go	Removed parameter name, making it anonymous in SetFunc declaration.

🐰✨
Changes here and changes there,
Unused params no longer stare.
From server's core to test suite glare,
Simplified, refined, with care to spare.
🌟 In code we trust, to this we swear,
A cleaner base, for all to share. 🌿
🐾🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 4d84ec8 and 1521502.

Files selected for processing (4)

• pkg/app/server.go (1 hunks)
• pkg/callbacks/callbacks_test.go (3 hunks)
• pkg/callbacks/kvstore/kvstore_test.go (1 hunks)
• pkg/telemetry/telemetry_test.go (1 hunks)

Files skipped from review due to trivial changes (1)

• pkg/callbacks/callbacks_test.go

Additional comments not posted (3)

pkg/telemetry/telemetry_test.go (1)

14-14: The change to use an underscore _ for the unused parameter in the anonymous function within t.Run is a good practice for clarity and adhering to Go conventions.

pkg/app/server.go (1)

85-85: Removing the unused httprouter.Params parameter in the handlerWrapper function simplifies the middleware setup and adheres to best practices for clean code.

pkg/callbacks/kvstore/kvstore_test.go (1)

29-29: Making the data parameter anonymous in the SetFunc declaration is a good practice for indicating unused parameters and adhering to Go conventions.