Test cases from waiting to event driven style #369
Conversation
|
|
||
| // Gnosis Safe should execute an open order | ||
| // Funding ephemeral account with some ethers to pay for gas | ||
| // TODO: ephemeralWallet should broadcast this action |
There was a problem hiding this comment.
That's an interesting idea - curious for your rationale here
There was a problem hiding this comment.
Then it's more like a Tasit app clicking a "fund myself" button?
There was a problem hiding this comment.
I guess if a user in the Tasit app clicked fund myself, it would still work just as well if it deep-linked into Gnosis Safe app and then the Gnosis Safe app broadcast it, right?
There was a problem hiding this comment.
I think so, that test is using the gnosisOwner to call the gnosisSafe contract. So it's like to not having the ephemeral account as a signer and calling the gnosisSafeApp thru deep-link.
There was a problem hiding this comment.
Yep. So depending on the scope of this particular test, either option is a sensible choice.
Maybe add something from this GitHub comment thread to explain that in addition to the current TODO comment in the code?
There was a problem hiding this comment.
Ok, I'll do that.
Issue link
#329
#273
#219
#354 (comment)
Auto-close the issue?
Closes #273
Types of changes
Bug fix (non-breaking change that fixes an issue)
Meta (a change that affects future changes to this repo)
Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)
Notes
This change should be extended to all test cases of the project?