fix: remove unnecessary user position check in OrderManager and enabl…

…e postcode field by default

Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>

classes/OrderManager.php

@@ -145,9 +145,6 @@ public function validateDeliveryAddress(array $address)
             'address_1', 'address_2', 'city', 'state', 'postcode', 'country',
         ]));
 
-        if (!$this->location->requiresUserPosition())
-            return;
-
         $collection = app('geocoder')->geocode($addressString);
         if (!$collection || $collection->isEmpty())
             throw new ApplicationException(lang('igniter.local::default.alert_invalid_search_query'));

components/Checkout.php

@@ -74,7 +74,7 @@ public function defineProperties()
             'showPostcodeField' => [
                 'label' => 'Whether to display the postcode form field',
                 'type' => 'switch',
-                'default' => false,
+                'default' => true,
                 'validationRule' => 'required|boolean',
             ],
             'showCountryField' => [
@@ -251,7 +251,7 @@ public function onConfirm()
 
         $this->validateCheckoutSecurity();
 
-        return rescue(function () use ($data) {
+        return rescue(function() use ($data) {
             $order = $this->getOrder();
 
             $this->validateCheckout($data, $order);
@@ -269,7 +269,7 @@ public function onConfirm()
 
             if ($redirect = $this->isOrderMarkedAsProcessed())
                 return $redirect;
-        }, function (\Throwable $ex) {
+        }, function(\Throwable $ex) {
             flash()->warning($ex->getMessage())->important();
 
             return Redirect::back()->withInput();
@@ -349,7 +349,7 @@ protected function validateCheckout($data, $order)
             'email.unique' => lang('igniter.cart::default.checkout.error_email_exists'),
         ]);
 
-        if ($this->checkoutStep === 'details' && $order->isDeliveryType()) {
+        if ($this->checkoutStep === 'details' && $order->isDeliveryType() && Location::requiresUserPosition()) {
             $this->orderManager->validateDeliveryAddress(array_get($data, 'address', []));
         }