This repository has been archived by the owner on Oct 18, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance tests once again pass on PhantomJS 2.0.
Installing PhantomJS 2.0
PhantomJS 2.0 isn't fully out the door. Linux binaries aren't available from their site. Travis is hosting a 2.0 binary they built from source.
Installing on OS X
Working Theory
Twitter tests that had previously passed began to fail on PhantomJS 1.9.8 (and 1.9.7 I believe). I saw additional test failures locally on PhantomJS 1.9.7 as well.
My unsubstantiated suspicion is that earlier versions of Phantom were defaulting to an SSL protocol for which Twitter killed support in the wake of POODLE. The problem is that
twttr.ready
never fires, leading me to believe that the Twitter widgets.js script simply isn't arriving.PhantomJS Config Differences, 1.9.8 vs 2.0.0
https://gist.github.com/chrislopresto/426d617198c232469418#file-phantomjs_poodling-sh-L27