remove backend concept from Options
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
j042
commented
Nov 15, 2023
j042
commented
- for compatibility, kept backend argument (renamed to backends).
- added option for specifying default
- added tests
clemens-fricke
previously approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Looks good to me.
All examples run.
All tests were successful.
Some adaptations are needed in splinepy, but that is fine for this PR.
Before we increase the version number, I would like to look further into adding support for 2D and 3D graphics in ipynb natively in gustaf. I hope I will get to that before Christmas. I already have a spike running for this. I will need to test more thoroughly to be sure it works, but I am hopeful.
clemens-fricke
previously approved these changes
Dec 14, 2023
add support for UGrid name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.