added missing test #205
Merged
added missing test #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
clemens-fricke
approved these changes
Apr 23, 2024
Comment on lines
+150
to
+158
| assert dataholder.get("a") == 1 | ||
| # 2. key and default | ||
| assert dataholder.get("b", 2) == 2 | ||
| # 3. key and wrong default | ||
| assert dataholder.get("b", 3) == 2 | ||
| # 4. empty key - always None | ||
| assert dataholder.get("c") is None | ||
| # 5. empty key and default | ||
| assert dataholder.get("c", "123") == "123" |
There was a problem hiding this comment.
Could we have gotten this functionality through inheritance from a build-in class, like default dict?
There was a problem hiding this comment.
could, yes, I just didn't wanna inherit from the built-in classes
jzwar
approved these changes
Apr 24, 2024
|
|
||
| ta = new_tracked_array() | ||
| ta /= 1.5 | ||
| assert ta.modified |
There was a problem hiding this comment.
I would feel better if before the modification it had assert not ta.modified at least once
There was a problem hiding this comment.
That is in the new_tracked_array() function. At least he sets it to False in the function.
| assert value is not func() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helper classes didn't have tests. This one adds one for
data.py. Related to #202