Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept any number of order-queries for derivatives #337

Merged
merged 4 commits into from
Jan 24, 2024
Merged

accept any number of order-queries for derivatives #337

merged 4 commits into from
Jan 24, 2024

Conversation

j042
Copy link
Member

@j042 j042 commented Jan 11, 2024

Overview

Implements #248

Addressed issues

Showcase

A short / one-liner example to highlight the (new) feature

import splinepy
import numpy as np

q = np.random.random((10000, spline.para_dim))

assert np.allclose(
    spline.jacobian(q),
    spline.derivative(q, np.eye(spline.para_dim)).transpose(0, 2, 1)
)

Checklists

  • Documentations are up-to-date.
  • Added example(s)
  • Added test(s)

@j042 j042 requested a review from jzwar January 11, 2024 12:54
@jzwar
Copy link
Collaborator

jzwar commented Jan 15, 2024

There are no tests for the new feature.

Copy link
Collaborator

@jzwar jzwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Adding the tests, LGTM

@j042 j042 merged commit 9658f53 into main Jan 24, 2024
21 checks passed
@j042 j042 deleted the ft-#248 branch January 24, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants