helpers use weakref #350
Merged
helpers use weakref #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j042
requested review from
jzwar and
clemens-fricke
and removed request for
jzwar
jzwar
approved these changes
Feb 5, 2024
j042
force-pushed
the
cu-data_name-to-data
branch
from
3d5fb94 to
196c97f
Compare
j042
force-pushed
the
ft-helper-weakref
branch
from
830fc93 to
1d430c7
Compare
j042
commented
Feb 5, 2024
splinepy/helpme/check.py
Outdated
| @@ -53,7 +54,7 @@ def valid_queries(spline, queries): | |||
| return True | |||
|
|
|||
|
|
|||
| class Checker: | |||
| class Checker(_HelperBase): | |||
j042
force-pushed
the
ft-helper-weakref
branch
from
1d430c7 to
1e337ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
to avoid circular reference, we keep weakref of the helpee within helpers. See tataratat/gustaf#185.
Turns out, keeping everything weakref doesn't allow "chained"-one-line uses. So, we will just create helpers that don't have states on the fly. Ones that have states will use weakref - they are okay, since we won't use them in "chained"-one-lines.
Addressed issues
weakrefto save "helpee" #327