Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More More More More SVG #401

Merged
merged 7 commits into from
Apr 8, 2024
Merged

More More More More SVG #401

merged 7 commits into from
Apr 8, 2024

Conversation

jzwar
Copy link
Collaborator

@jzwar jzwar commented Mar 20, 2024

Overview

  • clean-up : write_png is now separate function because, who knows when we might need it again
  • font-family is no longer defaulted, because the standard font is nicer in most cases (allows for more flexibility)
  • control_points had a bug -> it overwrote all other control mesh options, now we have the same behaviour as for spp.show()
  • arrow_data_scale and vmin/vmax are now no longer fighting each other
  • Most importantly:
    ADD A COLOR BAR

Checklists

  • Documentations are up-to-date.
  • Added example(s)
  • Added test(s)

@jzwar
Copy link
Collaborator Author

jzwar commented Apr 3, 2024

Added another feature, because:

  • new flag n_colors

image

not as nice as

image

@jzwar
Copy link
Collaborator Author

jzwar commented Apr 4, 2024

related to tataratat/gustaf#201

Copy link
Member

@j042 j042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome and very useful! Thank you :)

@@ -96,12 +96,15 @@ def mean_curvature(data, on=None):
a.show_options["lighting"] = "off"
a.show_options["control_points"] = False
a.show_options["knots"] = False
# a.show_options["cmap_n_colors"] = 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# a.show_options["cmap_n_colors"] = 2
# a.show_options["cmap_n_colors"] = 2

is this left here for a reason?

@j042 j042 force-pushed the cu-svg-exports branch from b221893 to 6d7badb Compare April 8, 2024 12:11
@j042 j042 merged commit 95a98f3 into main Apr 8, 2024
20 checks passed
@j042 j042 deleted the cu-svg-exports branch April 8, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants