Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON wireformat fixes #41

Merged
merged 2 commits into from
Oct 22, 2023
Merged

JSON wireformat fixes #41

merged 2 commits into from
Oct 22, 2023

Conversation

tatethurston
Copy link
Owner

@tatethurston tatethurston commented Oct 18, 2023

Fixes #39

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 497 lines in your changes are missing coverage. Please review.

Comparison is base (383d9c5) 30.53% compared to head (e574eee) 32.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   30.53%   32.36%   +1.82%     
==========================================
  Files           7        8       +1     
  Lines        1575     2308     +733     
  Branches      519      808     +289     
==========================================
+ Hits          481      747     +266     
- Misses       1094     1561     +467     
Files Coverage Δ
e2e/serialization/message.pb.ts 82.07% <92.30%> (+0.39%) ⬆️
...ages/protoscript/src/codegen/autogenerate/index.ts 2.16% <2.88%> (+0.08%) ⬆️
e2e/serialization/json.pb.ts 39.93% <39.93%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatethurston tatethurston merged commit 3d81e56 into main Oct 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp JSON serialization incorrect
1 participant