Changed things as mentioned in issue 6 #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some things in the code as mentioned here: #6
In particular, the following changes should be of note:
Every
nn.Linear
instantiation is now replaced by theget_linear
function, which returns annn.Linear
with xavier init. This also affects how theE
andF
matrices were initialized.There are no more
w_q
,w_k
, andw_v
matrices in theLinearAttentionHead
module. Instead, in theMHAttention
module,to_{q,k,v}
is now aModuleList
, and there arenhead
nn.Linear
layers in each of them, each corresponding to the original weight matrix in the original paper.Fixed a bug where there were still
**kwargs
in the checkpoint function"C2"
.