Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtt is 0.0 in OnRecv callback? #17

Open
bronze1man opened this issue Nov 9, 2015 · 3 comments
Open

rtt is 0.0 in OnRecv callback? #17

bronze1man opened this issue Nov 9, 2015 · 3 comments

Comments

@bronze1man
Copy link

I did see that rtt is 0.0 in OnRecv callback.
Please look at this line, it is possiblie that the rtt is 0,and it call OnRecv.
https://github.com/tatsushid/go-fastping/blob/master/fastping.go#L653

I think this is bug, as my ping logger will get a 0 rtt for some real network routes.
It will lower the average rtt to an impossible value. (lower than the light rtt).

@bronze1man bronze1man changed the title OnRecv rtt return 0? rtt is 0.0 in OnRecv callback? Nov 9, 2015
@traveller42
Copy link

Looks to me as if rtt is only supported for icmp.

@kanocz
Copy link
Contributor

kanocz commented Jun 22, 2016

probably fixed with #26

@harshitha-bt
Copy link

But the change does not seem to have merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants