Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero rtt with invalid id/seq #26

Closed
wants to merge 1 commit into from
Closed

Conversation

kanocz
Copy link
Contributor

@kanocz kanocz commented Jun 22, 2016

In case of more instances of application which uses go-fastping is pinging same ip it's possible to get responces with zero rtt. This small patch fixes it

Copy link

@harshitha-bt harshitha-bt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with this change, the problem still persists when a number of devices are pinged at a certain interval.

@kanocz
Copy link
Contributor Author

kanocz commented Oct 1, 2016

this problem will be only in case of many parallel pings (hundreds or thousands), but not in case of pinging big number of hosts using one pinger

@kanocz kanocz closed this Apr 15, 2017
@kanocz kanocz deleted the seqFix branch April 15, 2017 13:40
@joestringer
Copy link

I can reproduce this issue with a single ping to a local IP. The OnRecv() callback is called with an RTT of zero. With a patch like this, OnRecv() is called after the ping is conducted, with a valid RTT value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants